Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222690123
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/readsupport/impl/DictionaryDecodeReadSupport.java
---
@@ -81,7 +82,24 @@
data[i] = dictionaries[i].getDictionaryValueForKey((int) data[i]);
}
}
- return (T)data;
+ return (T) data;
+ }
+
+ /**
+ * get carbonRow, including data and datatpes
+ *
+ * @param data row data
+ * @return CarbonRow Object
+ */
+ public T readCarbonRow(Object[] data) {
--- End diff --
Instead of changing the DictionaryDecodeReadSupport & other classes
hierarchy, I suggest to use a new Row class as utility and just provide
required methods to avoid impact on base code.
---
