Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r222691292
--- Diff: store/CSDK/CarbonReader.cpp ---
@@ -89,10 +89,18 @@ jboolean CarbonReader::hasNext() {
return hasNext;
}
+jobject CarbonReader::readNextCarbonRow() {
+ jclass carbonReader = jniEnv->GetObjectClass(carbonReaderObject);
+ jmethodID readNextCarbonRowID = jniEnv->GetMethodID(carbonReader,
"readNextCarbonRow",
+ "()Lorg/apache/carbondata/core/datastore/row/CarbonRow;");
+ jobject carbonRow = (jobject)
jniEnv->CallObjectMethod(carbonReaderObject, readNextCarbonRowID);
+ return carbonRow;
+}
+
jobjectArray CarbonReader::readNextRow() {
jclass carbonReader = jniEnv->GetObjectClass(carbonReaderObject);
- jmethodID readNextRow2ID = jniEnv->GetMethodID(carbonReader,
"readNextStringRow", "()[Ljava/lang/Object;");
- jobjectArray row = (jobjectArray)
jniEnv->CallObjectMethod(carbonReaderObject, readNextRow2ID);
+ jmethodID readNextStringRowID = jniEnv->GetMethodID(carbonReader,
"readNextStringRow", "()[Ljava/lang/Object;");
--- End diff --
We can remove "readNextStringRow" and add a utility method in JNI to
achieve the same.
---
