Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2729#discussion_r225037399
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java ---
@@ -261,6 +261,14 @@ public void readFields(DataInput in) throws
IOException {
this.doInvertedIndex = dimension.isUseInvertedIndex();
}
+ DimensionSpec(String columnName, DataType dataType, ColumnType
columnType) {
+ super(columnName, dataType, columnType);
+ }
+
+ public static DimensionSpec newInstance(String columnName, DataType
dataType,
--- End diff --
As you are exposing newInstance() method to create the object then both the
constructors can be made private. I think it is better to add newInstance() for
the old constructor also.
Same goes for MeasureSpec
---
