Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2729#discussion_r225087082
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/dimension/legacy/PrimitiveTypeColumnCodec.java
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.carbondata.core.datastore.page.encoding.dimension.legacy;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.carbondata.core.datastore.TableSpec;
+import org.apache.carbondata.core.datastore.columnar.PageIndexGenerator;
+import
org.apache.carbondata.core.datastore.columnar.PrimitivePageIndexGenerator;
+import org.apache.carbondata.core.datastore.page.ColumnPage;
+import
org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoder;
+import
org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoderMeta;
+import
org.apache.carbondata.core.datastore.page.encoding.DefaultEncodingFactory;
+import
org.apache.carbondata.core.datastore.page.statistics.PrimitivePageStatsCollector;
+import org.apache.carbondata.core.keygenerator.KeyGenerator;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.metadata.datatype.DataTypes;
+import org.apache.carbondata.core.util.ByteUtil;
+import org.apache.carbondata.format.Encoding;
+
+/**
+ * Codec class for primitive data type columns
+ */
+public class PrimitiveTypeColumnCodec extends IndexStorageCodec {
--- End diff --
EIther rename the class which should tell the work it does like
primitiveinvertedINdex codec or primitivedimensioncodec
---
