Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r225785597
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -228,9 +230,12 @@ class CarbonScanRDD[T: ClassTag](
statistic.addStatistics(QueryStatisticsConstants.BLOCK_ALLOCATION,
System.currentTimeMillis)
statisticRecorder.recordStatisticsForDriver(statistic, queryId)
statistic = new QueryStatistic()
- val carbonDistribution = CarbonProperties.getInstance().getProperty(
+ var carbonDistribution = CarbonProperties.getInstance().getProperty(
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION,
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION_DEFAULT)
+ if (directScan) {
+ carbonDistribution =
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION_MERGE_FILES
+ }
--- End diff --
We can use `val` in place of `var` and write the code as below
`val carbonDistribution = if (directScan) {
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION_MERGE_FILES
} else {
CarbonProperties.getInstance().getProperty(
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION,
CarbonCommonConstants.CARBON_TASK_DISTRIBUTION_DEFAULT)
}`
---
