[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2818#discussion_r225785705
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
 ---
    @@ -748,4 +754,8 @@ class CarbonScanRDD[T: ClassTag](
         vectorReader = boolean
       }
     
    +  // TODO find the better way set it.
    +  def setDirectScanSupport(boolean: Boolean): Unit = {
    --- End diff --
    
    give some meaningful name for variable `boolean`


---