[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

[kunal642]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2818#discussion_r226907173
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
 ---
    @@ -748,4 +754,8 @@ class CarbonScanRDD[T: ClassTag](
         vectorReader = boolean
       }
     
    +  // TODO find the better way set it.
    +  def setDirectScanSupport(boolean: Boolean): Unit = {
    --- End diff --
    
    can make directScan as a constructor parameter like '''var  directScan: 
Boolean = false'''
    
    Other flows can set using constructor and this method would not be 
required. scanRdd.directScan = true would do the job.


---