Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r228074939
  
    --- Diff: store/CSDK/CarbonReader.cpp ---
    @@ -19,15 +19,14 @@
     #include <jni.h>
     
     jobject CarbonReader::builder(JNIEnv *env, char *path, char *tableName) {
    -
         jniEnv = env;
         jclass carbonReaderClass = 
env->FindClass("org/apache/carbondata/sdk/file/CarbonReader");
         jmethodID carbonReaderBuilderID = 
env->GetStaticMethodID(carbonReaderClass, "builder",
    --- End diff --
    
    No please handle at once. Because these are same feature. suggest we fix it 
and make it clean.  we should not merge PR which has issues as if some user 
uses it, he will get jvm crash 


---

Reply via email to