Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2792#discussion_r228124647
--- Diff: store/CSDK/src/CarbonReader.cpp ---
@@ -19,15 +19,14 @@
#include <jni.h>
jobject CarbonReader::builder(JNIEnv *env, char *path, char *tableName) {
-
jniEnv = env;
jclass carbonReaderClass =
env->FindClass("org/apache/carbondata/sdk/file/CarbonReader");
jmethodID carbonReaderBuilderID =
env->GetStaticMethodID(carbonReaderClass, "builder",
"(Ljava/lang/String;Ljava/lang/String;)Lorg/apache/carbondata/sdk/file/CarbonReaderBuilder;");
- jstring jpath = env->NewStringUTF(path);
+ jstring jPath = env->NewStringUTF(path);
jstring jtableName = env->NewStringUTF(tableName);
jvalue args[2];
- args[0].l = jpath;
+ args[0].l = jPath;
args[1].l = jtableName;
carbonReaderBuilderObject =
env->CallStaticObjectMethodA(carbonReaderClass, carbonReaderBuilderID, args);
return carbonReaderBuilderObject;
--- End diff --
No need to return object because we are storing this variable. make it void.
---
