[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r228126086
  
    --- Diff: store/CSDK/src/CarbonReader.h ---
    @@ -35,6 +40,13 @@ class CarbonReader {
          */
         jobject carbonReaderObject;
     
    +public:
    +
    +    /**
    +     * jni env
    +     */
    +    JNIEnv *jniEnv;
    +
         /**
          * create a CarbonReaderBuilder object for building carbonReader,
          * CarbonReaderBuilder object  can configure different parameter
    --- End diff --
    
    builder, projection, withHaaddopConf -- No need to have return value. They 
are not used. we can return void


---