akashrn5 commented on a change in pull request #3584: [WIP] Support
SegmentLevel MinMax for better Pruning and less driver memory usage for cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r379377714
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -1265,6 +1292,21 @@ void addPath(String path, FolderDetails details) {
public void setOptions(Map<String, String> options) {
this.options = options;
}
+
+ public List<SegmentMinMax> getSegmentMinMax() {
+ List<SegmentMinMax> segmentMinMaxList = null;
+ try {
+ segmentMinMaxList =
+ (List<SegmentMinMax>)
ObjectSerializationUtil.convertStringToObject(segmentMinMax);
+ } catch (IOException e) {
+ LOGGER.error("Error while getting segment minmax");
+ }
+ return segmentMinMaxList;
Review comment:
i recommend to return empty list instead of null and all the place remove
null check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
