akashrn5 commented on a change in pull request #3584: [WIP] Support
SegmentLevel MinMax for better Pruning and less driver memory usage for cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r379339875
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
##########
@@ -211,15 +292,22 @@ private void
getTableBlockUniqueIdentifierWrappers(List<PartitionSpec> partition
public Set<TableBlockIndexUniqueIdentifier>
getTableBlockIndexUniqueIdentifiers(Segment segment)
Review comment:
replace this method with this and verify once
SegmentBlockInfo segmentBlockInfo = segmentMap.get(segment.getSegmentNo());
Set<TableBlockIndexUniqueIdentifier> tableBlockIndexUniqueIdentifiers;
if (null != segmentBlockInfo) {
segment.setSegmentMinMax(segmentMap.get(segment.getSegmentNo()).getSegmentMinMax());
tableBlockIndexUniqueIdentifiers =
segmentBlockInfo.getTableBlockIndexUniqueIdentifiers();
} else {
tableBlockIndexUniqueIdentifiers =
BlockletDataMapUtil.getTableBlockUniqueIdentifiers(segment);
if (tableBlockIndexUniqueIdentifiers.size() > 0) {
segmentMap.put(segment.getSegmentNo(),
new SegmentBlockInfo(tableBlockIndexUniqueIdentifiers,
segment.getSegmentMinMax()));
}
}
return tableBlockIndexUniqueIdentifiers;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
