akashrn5 commented on a change in pull request #3584: [WIP] Support SegmentLevel MinMax for better Pruning and less driver memory usage for cache URL: https://github.com/apache/carbondata/pull/3584#discussion_r379377880
########## File path: core/src/main/java/org/apache/carbondata/core/util/SegmentMinMax.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.core.util; + +import java.io.Serializable; +import java.util.Map; + +/** + * Holds Min, Max and columnCardinality values for each segment block + */ +public class SegmentMinMax implements Serializable { + + /** + * Map of column names and it's block level min values + */ + private Map<String, byte[]> minValues; + + /** + * Map of column names and it's block level max values + */ + private Map<String, byte[]> maxValues; + + SegmentMinMax(Map<String, byte[]> minValues, Map<String, byte[]> maxValues) { + this.minValues = minValues; + this.maxValues = maxValues; + } + + public Map<String, byte[]> getMinValues() { + return minValues; + } + + public void setMinValues(Map<String, byte[]> minValues) { + this.minValues = minValues; + } + + public Map<String, byte[]> getMaxValues() { + return maxValues; + } + + public void setMaxValues(Map<String, byte[]> maxValues) { + this.maxValues = maxValues; + } +} Review comment: addnew line at end of class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
