akashrn5 commented on a change in pull request #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort URL: https://github.com/apache/carbondata/pull/3645#discussion_r386083102
########## File path: processing/src/main/java/org/apache/carbondata/processing/loading/constants/DataLoadProcessorConstants.java ########## @@ -38,4 +38,6 @@ public static final String FACT_FILE_PATH = "FACT_FILE_PATH"; + // to indicate that it is optimized insert flow without rearrange of each data rows + public static final String NO_REARRANGE_OF_ROWS = "NO_REARRANGE_OF_ROWS"; Review comment: please add a default value instead of giving true or false ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
