ajantha-bhat commented on a change in pull request #3645: [CARBONDATA-3728] Fix
insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386087434
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
##########
@@ -401,6 +420,33 @@ public static boolean isHeaderValid(String tableName,
String[] csvHeader,
return noDicSortColMapping;
}
+ /**
+ * get mapping based on data fields order
+ *
+ * @param dataFields
+ * @return
+ */
+ public static boolean[] getNoDictSortColMappingAsDataFieldOrder(DataField[]
dataFields) {
+ List<Boolean> noDicSortColMap = new ArrayList<>();
+ for (DataField dataField : dataFields) {
Review comment:
all these functions are replicated from the same file. Whole sort step has
dictionary and no-dictionary mapping.
I do agree that we don't have dictionary. But cannot change all the current
sort step variables and logic in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
