akashrn5 commented on a change in pull request #3645: [CARBONDATA-3728] Fix 
insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386082610
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ##########
 @@ -457,6 +534,34 @@ public static boolean isHeaderValid(String tableName, 
String[] csvHeader,
     return noDictSortAndNoSortTypes;
   }
 
+  /**
+   * Get the data types of the no dictionary sort columns as per dataFields 
order
 
 Review comment:
   i think since we removed dictionary, we should avoid mentioning noDict in 
all places

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to