QiangCai commented on a change in pull request #4013:
URL: https://github.com/apache/carbondata/pull/4013#discussion_r534742148
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java
##########
@@ -146,8 +146,8 @@ public static void
cleanStaleSegmentsForPartitionTable(CarbonTable carbonTable)
* in the metadata folder and is not present in the table status file is
considered as a
* stale segment. Only comparing from tablestatus file, not checking
tablestatus.history file
*/
- private static void getStaleSegmentFiles(CarbonTable carbonTable,
List<String> staleSegmentFiles,
- List<String> redundantSegmentFile) {
+ private static void collectStaleSegmentFiles(CarbonTable carbonTable,
Review comment:
this method need return two lists, so it passes two lists in parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
