QiangCai commented on a change in pull request #4013:
URL: https://github.com/apache/carbondata/pull/4013#discussion_r534744818
##########
File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java
##########
@@ -208,6 +205,14 @@ public static boolean isTrashRetentionTimeoutExceeded(long
fileTimestamp) {
return difference > retentionMilliSeconds;
}
+ /**
+ * whether trash data outside of .Trash folder is time out
+ */
+ public static boolean isTrashDataTimeout(long fileTimestamp) {
+ return isTrashRetentionTimeoutExceeded(fileTimestamp) &&
Review comment:
isTrashRetentionTimeoutExceeded: whether trash data inside of .Trash
folder is time out
isTrashDataTimeout: whether trash data outside of .Trash folder is time out
TrashRetentionTimeout can be 0, but MaxQueryTimeout not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
