ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534784870
########## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.trash + +import scala.collection.JavaConverters._ + +import org.apache.carbondata.common.logging.LogServiceFactory +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.indexstore.PartitionSpec +import org.apache.carbondata.core.locks.{CarbonLockUtil, ICarbonLock, LockUsage} +import org.apache.carbondata.core.metadata.SegmentFileStore +import org.apache.carbondata.core.metadata.schema.table.CarbonTable +import org.apache.carbondata.core.statusmanager.SegmentStatusManager +import org.apache.carbondata.core.util.{CarbonProperties, CleanFilesUtil, TrashUtil} + +/** + * This object will manage the following data. + * 1. .Trash folder + * 2. stale segments without metadata + * 3. expired segments (MARKED_FOR_DELETE, Compacted, In Progress) + */ +object DataTrashManager { + private val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName) + + /** + * clean garbage data + * 1. clean .Trash folder + * 2. clean stale segments without metadata + * 3. clean expired segments (MARKED_FOR_DELETE, Compacted, In Progress) + * + * @param carbonTable : CarbonTable Object + * @param partitionSpecs : Hive Partitions details + */ + def cleanGarbageData( + carbonTable: CarbonTable, + force: Boolean = false, + partitionSpecs: Option[Seq[PartitionSpec]] = None): Unit = { + var carbonCleanFilesLock: ICarbonLock = null + val absoluteTableIdentifier = carbonTable.getAbsoluteTableIdentifier + try { + val errorMsg = "Clean files request is failed for " + + s"${ carbonTable.getQualifiedName }" + + ". Not able to acquire the clean files lock due to another clean files " + + "operation is running in the background." + carbonCleanFilesLock = CarbonLockUtil.getLockObject(absoluteTableIdentifier, + LockUsage.CLEAN_FILES_LOCK, errorMsg) + // step 1: clean trash folder + cleanTrashFolder(carbonTable, force) + // step 2: clean stale segments which are not exists in metadata + cleanStaleSegments(carbonTable) Review comment: `moveStaleSegmentsToTrash` is the better name for this function ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
