Karan980 commented on a change in pull request #4048:
URL: https://github.com/apache/carbondata/pull/4048#discussion_r542119343
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -1125,19 +1125,21 @@ public static void deleteSegment(String tablePath,
Segment segment,
SegmentFileStore fileStore = new SegmentFileStore(tablePath,
segment.getSegmentFileName());
List<String> indexOrMergeFiles =
fileStore.readIndexFiles(SegmentStatus.SUCCESS, true,
FileFactory.getConfiguration());
- Map<String, List<String>> indexFilesMap = fileStore.getIndexFilesMap();
Review comment:
I think this check is fine. Because for setting the isRelative variable
same logic is used in FolderDetails class. If i use isRelative variable here, i
have to generate the keys for locationMap because this variable is present
inside loactionMap.
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala
##########
@@ -962,6 +962,88 @@ class AddSegmentTestCase extends QueryTest with
BeforeAndAfterAll {
sql(s"drop table $tableName")
}
Review comment:
TestCases moved to testCleanFilesCommand and also added testCases for
partition table and mixed formats.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
