[ https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515351#comment-15515351 ]
ASF GitHub Bot commented on CARBONDATA-208: ------------------------------------------- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80179616 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java --- @@ -52,12 +56,27 @@ public static LoadStatistics getLoadStatisticsInstance() { return LoadStatisticsInstance; } - private static DriverQueryStatisticsRecorder genQueryStatisticsRecorderInstance() { - return DriverQueryStatisticsRecorder.getInstance(); + private static QueryStatisticsRecorder genQueryStatisticsRecorderInstance() { --- End diff -- rename all the factory function in this class to `createXXX` > User should be able to turn on and off the STATISTIC log > -------------------------------------------------------- > > Key: CARBONDATA-208 > URL: https://issues.apache.org/jira/browse/CARBONDATA-208 > Project: CarbonData > Issue Type: Bug > Reporter: Jacky Li > Priority: Minor > Fix For: 0.2.0-incubating > > > Currently there are many STATISTIC log for performance tuning purpose, but it > should be configurable by the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)