Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052521
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v1/CarbonFactDataWriterImplV1.java
---
@@ -373,7 +373,7 @@ protected void writeBlockletInfoToFile(FileChannel
channel, String filePath)
FileFooter convertFileMeta = CarbonMetadataUtil
.convertFileFooter(blockletInfoList, localCardinality.length,
localCardinality,
thriftColumnSchemaList, dataWriterVo.getSegmentProperties());
- fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(), filePath,
currentPosition);
+ fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(),
carbonDataFileName, currentPosition);
--- End diff --
Please align the parameter name(filePath) for fillBlockIndexInfoDetails of
AbstractFactDataWriter.java
For example :
protected void fillBlockIndexInfoDetails(long numberOfRows,
String carbonDataFileName, long currentPosition)
Please modify accordingly for all part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
