Github user watermen commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108081845
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -528,8 +528,7 @@ protected void fillBlockIndexInfoDetails(long
numberOfRows, String filePath,
org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex
blockletIndex =
new
org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex(btree, minmax);
BlockIndexInfo blockIndexInfo =
- new BlockIndexInfo(numberOfRows, filePath.substring(0,
filePath.lastIndexOf('.')),
- currentPosition, blockletIndex);
+ new BlockIndexInfo(numberOfRows, filePath, currentPosition,
blockletIndex);
--- End diff --
# Before
We pass the fileName and in the end of fileName is `.inprogress`, so we
need to do substring.
```java
this.fileName = dataWriterVo.getStoreLocation() + File.separator +
carbonDataFileName + CarbonCommonConstants.FILE_INPROGRESS_STATUS;
```
# After
We pass the carbonDataFileName and we don't need to do substring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
