[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

[chenliang613]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/696
  
    @watermen 
    
    Thanks for your contribution, everything looks good.
    Only one comment, in AbstractFactDataWriter.java, there are two 
parameters(fileName, carbonDataFileName) , what is the different ?
    /**
       * file name
       */
      protected String fileName;
    
      /**
       * The name of carbonData file
       */
      protected String carbonDataFileName;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---