Myasuka commented on code in PR #1824:
URL: 
https://github.com/apache/incubator-celeborn/pull/1824#discussion_r1301222722


##########
docker/Dockerfile:
##########
@@ -35,6 +35,8 @@ RUN set -ex && \
     useradd  --uid=${celeborn_uid} --gid=${celeborn_gid} celeborn -d 
/home/celeborn -m && \
     mkdir -p ${CELEBORN_HOME}
 
+ENV LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so

Review Comment:
   From my experience, I think we could use code to switch the environment via 
`uname -m` (we can refer to the [flink-docker 
code](https://github.com/apache/flink-docker/blob/45c6d230407d89aa83b0d170dd056d6868cf808e/1.17/scala_2.12-java8-ubuntu/docker-entrypoint.sh#L92C3-L109)).
 
   
   I think it make sense to make this option configurable and we shall enable 
this by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to