Myasuka commented on code in PR #1824:
URL:
https://github.com/apache/incubator-celeborn/pull/1824#discussion_r1301311109
##########
docker/Dockerfile:
##########
@@ -35,6 +35,8 @@ RUN set -ex && \
useradd --uid=${celeborn_uid} --gid=${celeborn_gid} celeborn -d
/home/celeborn -m && \
mkdir -p ${CELEBORN_HOME}
+ENV LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so
Review Comment:
Thanks for the clarification. Reconfigure the environment `LD_PRELOAD` in
script would align the behavior. However, once running outside the container,
the location of `libjemalloc.so` would be totally different in different
versions of linux environment. To not extend this scope of this PR (mainly
focus on the container environment), I think we would not pay too much efforts
to find the location of `libjemalloc.so`. The improvement could be done for
others who runn Celeborn in non-container environments.
In a nutshell, I think moving the setting of `LD_PRELOAD` to environment
related scripts would be a good idea, but we will only detect the
`/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so` location in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
