pan3793 commented on code in PR #1824:
URL:
https://github.com/apache/incubator-celeborn/pull/1824#discussion_r1301244577
##########
docker/Dockerfile:
##########
@@ -35,6 +35,8 @@ RUN set -ex && \
useradd --uid=${celeborn_uid} --gid=${celeborn_gid} celeborn -d
/home/celeborn -m && \
mkdir -p ${CELEBORN_HOME}
+ENV LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so
Review Comment:
`uname -m` would be a good idea, but does it work in ENV command?
Also, is it only beneficial inside the container? if not, we'd better supply
a general solution. e.g. port the jemalloc detection and enabling logic into
the bootstrap shell script, and introduce an env var like
CELEBORN_DISABLE_JEMALLOC to make it configurable.
Then, the behavior is consistent inside and outside of the container:
- enable jemalloc by default when libjemalloc.so is available
- user can set CELEBORN_DISABLE_JEMALLOC=1 to explicitly disable the
jemalloc usage
thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
