akpatnam25 opened a new pull request, #2064:
URL: https://github.com/apache/incubator-celeborn/pull/2064
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
The changes are:
- persisting data to local disk before replicating.
- refactor write since that code is reused in multiple places
### Why are the changes needed?
Changes are needed because currently the primary will send a response back
to client just if replica is success/failure. It does not take into account of
primary. We should persist in primary first, and then proceed to replica.
Primary persist is done async anyways. Additionally, this will prevent data
corruption issues when data may not be present properly in primary but only on
replica, but client fetches only from primary.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Will let CI run, and also tested on our internal cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
