mridulm commented on code in PR #2064:
URL:
https://github.com/apache/incubator-celeborn/pull/2064#discussion_r1384407622
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -21,6 +21,10 @@ import java.nio.ByteBuffer
import java.util.concurrent.{ConcurrentHashMap, ThreadPoolExecutor}
import java.util.concurrent.atomic.{AtomicBoolean, AtomicIntegerArray}
+import scala.concurrent.ExecutionContext.Implicits.global
Review Comment:
Instead of depending on `global`, rely on an explicitly create threadpool
which is appropriately sized (not sure if we need different pools for
replication vs local write).
Something like:
```
val threadPool = ThreadUtils.newDaemonFixedThreadPool(parallelism,
"push-data-handler")
...
implicit val executionContext: ExecutionContext =
ExecutionContext.fromExecutor(threadPool)
Future { ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
