otterc commented on code in PR #2064:
URL:
https://github.com/apache/incubator-celeborn/pull/2064#discussion_r1379767129
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -245,6 +247,11 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
fileWriter.decrementPendingWrites()
return;
}
+ // Write to local async.
+ // If write to buffer fails, respond back to client with failure. Else
proceed with replication.
+ if (!writeDataWithExceptionHandling(fileWriter, body, shuffleKey,
callbackWithTimer)) {
Review Comment:
I don't think we should do this before data is pushed to replica
asynchronously. This adds a delay to start of replication which could be
significant when append does involve a flush.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
