akpatnam25 commented on code in PR #2064:
URL:
https://github.com/apache/incubator-celeborn/pull/2064#discussion_r1385688498
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1246,6 +1215,28 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
}
}
+ def writeDataWithExceptionHandling(
+ fileWriter: FileWriter,
+ body: ByteBuf,
+ shuffleKey: String): Future[Unit] = {
+ Future {
+ try {
+ fileWriter.write(body)
+ } catch {
+ case e: AlreadyClosedException =>
Review Comment:
Yes, but all they do with that is log the exception. In the new code, I am
throwing it anyways, which will get propagated/logged anyways. It goes via
`callbackWithTimer.onFailure(e)` to client, which will log the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
