mridulm commented on code in PR #2064:
URL:
https://github.com/apache/incubator-celeborn/pull/2064#discussion_r1385910117
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -21,6 +21,10 @@ import java.nio.ByteBuffer
import java.util.concurrent.{ConcurrentHashMap, ThreadPoolExecutor}
import java.util.concurrent.atomic.{AtomicBoolean, AtomicIntegerArray}
+import scala.concurrent.ExecutionContext.Implicits.global
Review Comment:
You need a threadpool for the `Future` - the global threadpool gets used for
a bunch of things, and if overloaded, it will result in not responding to
clients on time: which is why a different threadpool.
In either case, we should not rely on `Implicits.global`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
