waitinfuture commented on PR #2064: URL: https://github.com/apache/incubator-celeborn/pull/2064#issuecomment-1801389364
> > I think we should add some UTs. > > Currently there is not much unit test coverage for `PushDataHandler` at all. I think it is mostly tested via the cluster tests in `org.apache.celeborn.service.deploy.cluster`. Given that `PushDataHandler` has a lot of async tasks, I think in order to write a UT for it now we would have to restructure the code quite a bit to write a proper UT. @waitinfuture lmk what you think You are right, currently the UT coverage for Celeborn is relatively low. It will be great to add more UTs. Refactoring is also welcome as long as it helps and does not introduce regression :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
