akpatnam25 commented on code in PR #2064:
URL:
https://github.com/apache/incubator-celeborn/pull/2064#discussion_r1387672059
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -516,7 +517,18 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
fileWriters.foreach(_.decrementPendingWrites())
return
}
-
+ def writePushMergedDataLocal() = {
+ var fileWriter: FileWriter = null
+ batchOffsets.zip(fileWriters).map { case (offset, writer) =>
+ fileWriter = writer
+ val batchBody = body.slice(
+ body.readerIndex() + offset,
+ if (offset == batchOffsets.last) body.readableBytes() - offset
+ else batchOffsets(batchOffsets.indexOf(offset) + 1) - offset)
+ writeDataWithExceptionHandling(fileWriter, batchBody, shuffleKey)
Review Comment:
we won't make this many futures in the new implementation you suggested, so
will resolve this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
