pan3793 commented on code in PR #2084:
URL:
https://github.com/apache/incubator-celeborn/pull/2084#discussion_r1387672474
##########
client/src/main/java/org/apache/celeborn/client/ReviveManager.java:
##########
@@ -124,4 +123,8 @@ public void addRequest(ReviveRequest request) {
logger.error("Exception when put into requests!", e);
}
}
+
+ public void close() {
+ batchReviveRequestScheduler.shutdown();
Review Comment:
should we shutdown immediately or give it a meaningful timeout, otherwise it
may block the shutdown procedure.
Hadoop MRG has default 30s timeout, all shutdown hooks share that threshold,
one hook blocking will cause the subsequent hooks skip to execute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
