pan3793 commented on code in PR #2084:
URL:
https://github.com/apache/incubator-celeborn/pull/2084#discussion_r1387730546
##########
client/src/main/java/org/apache/celeborn/client/ReviveManager.java:
##########
@@ -124,4 +125,8 @@ public void addRequest(ReviveRequest request) {
logger.error("Exception when put into requests!", e);
}
}
+
+ public void close() {
+ ThreadUtils.shutdown(batchReviveRequestScheduler, Duration.apply("800ms"));
Review Comment:
I'm not sure it's a good timeout, but make sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
