onebox-li commented on code in PR #2084:
URL:
https://github.com/apache/incubator-celeborn/pull/2084#discussion_r1387817454
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -601,13 +601,13 @@ protected void limitZeroInFlight(String mapKey, PushState
pushState) throws IOEx
}
/**
- * check if a newer PartitionLocation(with larger epoch) exists in local
cache
+ * Check if a newer PartitionLocation(with larger epoch) exists in local
cache.
*
- * @param shuffleMap
- * @param partitionId
- * @param epoch
- * @param wait whether to wait for some time for a newer PartitionLocation
- * @return
+ * @param shuffleMap The mapping between shuffle id and partition location.
+ * @param partitionId The id of partition.
+ * @param epoch The epoch of revive.
+ * @param wait whether to wait for some time for a newer partition location.
Review Comment:
nit: Whether
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
