otterc commented on code in PR #2123:
URL:
https://github.com/apache/incubator-celeborn/pull/2123#discussion_r1412824083
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -726,17 +735,14 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
client: TransportClient,
message: RequestMessage,
requestId: Long,
- handler: () => Unit): Unit = {
+ handler: () => Unit,
+ callback: RpcResponseCallback): Unit = {
try {
handler()
} catch {
case e: Exception =>
logError(s"Error while handle${message.`type`()} $message", e)
- client.getChannel.writeAndFlush(new RpcFailure(
- requestId,
- Throwables.getStackTraceAsString(e)))
- } finally {
- message.body().release()
Review Comment:
`callback.onFailure(e)` covers `client.getChannel.writeAndFlush(new
RpcFailure(
requestId,
Throwables.getStackTraceAsString(e)))`
`message.body().release()` will be called in
`TransportRequestHandler.processRpcMessage...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
