waitinfuture commented on code in PR #2123:
URL:
https://github.com/apache/incubator-celeborn/pull/2123#discussion_r1420710525
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala:
##########
@@ -36,7 +36,7 @@ import org.apache.celeborn.common.internal.Logging
import org.apache.celeborn.common.network.TransportContext
import org.apache.celeborn.common.network.buffer.NioManagedBuffer
import org.apache.celeborn.common.network.client._
-import org.apache.celeborn.common.network.protocol.{OneWayMessage =>
NOneWayMessage, RequestMessage => NRequestMessage, RpcFailure => NRpcFailure,
RpcRequest, RpcResponse}
+import org.apache.celeborn.common.network.protocol.{RequestMessage =>
NRequestMessage, RpcFailure => NRpcFailure, RpcRequest}
Review Comment:
nit: `RpcFailure => NRpcFailure` is unused
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala:
##########
@@ -36,7 +36,7 @@ import org.apache.celeborn.common.internal.Logging
import org.apache.celeborn.common.network.TransportContext
import org.apache.celeborn.common.network.buffer.NioManagedBuffer
Review Comment:
nit: unused import, same with `com.google.common.base.Throwables`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
