waitinfuture commented on PR #2123: URL: https://github.com/apache/incubator-celeborn/pull/2123#issuecomment-1847577970
> The class name `BaseMessageHandler` is quite confusing, as we have another irrelevant class `MessageHandler`, would it be better to rename it to `RpcHandler` as Spark does? @waitinfuture `BaseMessageHandler`'s children include `FetchHandler`, `PushDataHandler` and `NettyRpcHandler`, so it'll be confusing if renamed to `RpcHandler`. Maybe we can think of a better one in future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
