mridulm commented on code in PR #2231:
URL: 
https://github.com/apache/incubator-celeborn/pull/2231#discussion_r1457760885


##########
common/src/test/java/org/apache/celeborn/common/network/sasl/SaslTestBase.java:
##########
@@ -44,7 +44,9 @@ public class SaslTestBase {
 
   @BeforeClass
   public static void setup() {
-    SecretRegistryImpl.getInstance().register(TEST_USER, TEST_SECRET);
+    if (!SecretRegistryImpl.getInstance().isRegistered(TEST_USER)) {
+      SecretRegistryImpl.getInstance().register(TEST_USER, TEST_SECRET);

Review Comment:
   We should probably have an AfterClass to clean this up for tests :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to