waitinfuture commented on code in PR #2231:
URL:
https://github.com/apache/incubator-celeborn/pull/2231#discussion_r1460697123
##########
common/src/main/java/org/apache/celeborn/common/network/sasl/SecretRegistryImpl.java:
##########
@@ -33,10 +33,12 @@ public static SecretRegistryImpl getInstance() {
private final ConcurrentHashMap<String, String> secrets = new
ConcurrentHashMap<>();
+ @Override
public void register(String appId, String secret) {
secrets.put(appId, secret);
Review Comment:
> Once the application has registered, it should not register again even if
a new `TransportClient` is created. The `RegistrationClientBootstrap` will be
added as a client bootstrap but it will just authenticate the connection and
not register. The below condition would handle that:
>
> ```
> if (registrationInfo.getRegistrationState() ==
RegistrationInfo.RegistrationState.REGISTERED) {
> LOG.info("client has already registered, skip register.");
> doSaslBootstrap(client, channel);
> return;
> }
> ```
Got it, thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
