mridulm commented on code in PR #2346:
URL:
https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1509964592
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -850,6 +852,27 @@ private[celeborn] class Master(
logInfo(s"Offered extra $offerSlotsExtraSize slots for $shuffleKey")
}
+ if (authEnabled) {
+ // Pass application registration information to the workers
+ val pbApplicationMeta = PbApplicationMeta.newBuilder()
+ .setAppId(requestSlots.applicationId)
+ .setSecret(secretRegistry.getSecretKey(requestSlots.applicationId))
+ .build()
+ val transportMessage =
+ new TransportMessage(MessageType.APPLICATION_META,
pbApplicationMeta.toByteArray)
+
+ slots.keySet().asScala.foreach { worker =>
+ try {
+ logInfo(s"Sending app registration info to
${worker.host}:${worker.internalPort}")
+ internalRpcEnvInUse.setupEndpointRef(
+ RpcAddress.apply(worker.host, worker.internalPort),
+ RpcNameConstants.WORKER_INTERNAL_EP).send(transportMessage)
+ } catch {
+ case t: Throwable =>
Review Comment:
I understand the intent, but catching `Throwable` is typically not a great
idea.
At a minimum, let us move this to `ExceptionUtils` (similar to
`Utils.tryLogNonFatalError` in spark) - we might want to evolve this in future
for fatal exception to be handled by some `UncaughtExceptionHandler` for
example; and having this pattern spread across code would make that tricky.
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
