otterc commented on code in PR #2346:
URL:
https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1510024392
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -850,6 +852,27 @@ private[celeborn] class Master(
logInfo(s"Offered extra $offerSlotsExtraSize slots for $shuffleKey")
}
+ if (authEnabled) {
+ // Pass application registration information to the workers
+ val pbApplicationMeta = PbApplicationMeta.newBuilder()
+ .setAppId(requestSlots.applicationId)
+ .setSecret(secretRegistry.getSecretKey(requestSlots.applicationId))
+ .build()
+ val transportMessage =
+ new TransportMessage(MessageType.APPLICATION_META,
pbApplicationMeta.toByteArray)
+
+ slots.keySet().asScala.foreach { worker =>
+ try {
+ logInfo(s"Sending app registration info to
${worker.host}:${worker.internalPort}")
+ internalRpcEnvInUse.setupEndpointRef(
+ RpcAddress.apply(worker.host, worker.internalPort),
+ RpcNameConstants.WORKER_INTERNAL_EP).send(transportMessage)
+ } catch {
+ case t: Throwable =>
Review Comment:
Actually the try/catch is not required here so I removed it. Any exceptions
with sending the one way message is caught and logged in the
`OneWayOutboxMessage.onFailure`
[here](https://github.com/apache/incubator-celeborn/blob/93d2b9f47fb69ec2ba3694df5d30a8c91c754469/common/src/main/scala/org/apache/celeborn/common/rpc/netty/Outbox.scala#L47).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
