otterc commented on code in PR #2367: URL: https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1518462533
########## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala: ########## @@ -293,6 +293,9 @@ private[celeborn] class Worker( private val masterClient = new MasterClient(internalRpcEnvInUse, conf, true) + private val rackResolver = new CelebornRackResolver(conf) + private val networkLocation = rackResolver.resolve(host).getNetworkLocation Review Comment: Are we making the assumption here that the `DNSToSwitchMapping` implementation is present on all the Worker nodes? Earlier the assumption was that this was only present on the Master node. In existing production environment, if this is not present on the worker nodes, this will break the replication across racks feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
