otterc commented on code in PR #2367:
URL:
https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1518469162
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws
IOException {
.peek(
workerInfo -> {
// Reset worker's network location with current master's
configuration.
- workerInfo.networkLocation_$eq(
-
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+ if
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+ workerInfo.networkLocation_$eq(
+
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
Review Comment:
I don't see a change in `PbSerDeUtils.toPbWorkerInfo()` so that
networkLocation is also persisted in the file. So, in the case when the worker
is sending its location, it will not be recovered from Ratis?
Also, if we persist it to file, then we don't need to 332-335 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
