akpatnam25 commented on code in PR #2367:
URL:
https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1519200560
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws
IOException {
.peek(
workerInfo -> {
// Reset worker's network location with current master's
configuration.
- workerInfo.networkLocation_$eq(
-
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+ if
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+ workerInfo.networkLocation_$eq(
+
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
Review Comment:
`PbSerDeUtils.fromPbWorkerResource` and `PbSerDeUtils.toPbWorkerResource`
already have `networkLocation as a field. We persist it to Ratis in
`AbstractMetaManager.updateRegisterWorkerMeta`. We need the L332-L335 in case
the worker's networkLocation is still set to default rack. In this case, we can
retry to see if it can be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
