mridulm commented on code in PR #2471:
URL: https://github.com/apache/celeborn/pull/2471#discussion_r1573952743


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1371,12 +1397,24 @@ class CelebornConf(loadDefaults: Boolean) extends 
Cloneable with Logging with Se
 
 object CelebornConf extends Logging {
 
-  val TRANSPORT_MODULE_FALLBACKS = Map(
-    "rpc_service" -> "rpc",
-    "rpc_app" -> "rpc",
+  val TRANSPORT_MODULE_FALLBACKS: Map[String, String] = Map(

Review Comment:
   Yes, this will be documented as part documenting the SSL feature.
   See [this 
comment](https://issues.apache.org/jira/browse/CELEBORN-1353?focusedCommentId=17837988&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17837988)
 in particular to ensure it is not missed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to