SteNicholas commented on code in PR #2471:
URL: https://github.com/apache/celeborn/pull/2471#discussion_r1574126043
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1371,12 +1397,24 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
object CelebornConf extends Logging {
- val TRANSPORT_MODULE_FALLBACKS = Map(
- "rpc_service" -> "rpc",
- "rpc_app" -> "rpc",
+ val TRANSPORT_MODULE_FALLBACKS: Map[String, String] = Map(
Review Comment:
@mridulm, do the fallbacks have any test case to verify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]