mridulm commented on code in PR #2471:
URL: https://github.com/apache/celeborn/pull/2471#discussion_r1574141536
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1371,12 +1397,24 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
object CelebornConf extends Logging {
- val TRANSPORT_MODULE_FALLBACKS = Map(
- "rpc_service" -> "rpc",
- "rpc_app" -> "rpc",
+ val TRANSPORT_MODULE_FALLBACKS: Map[String, String] = Map(
Review Comment:
Yes, these were added in previous PR btw.
See
[here](https://github.com/apache/celeborn/blob/11c7d1080c76b86061b46ae3f99ceade37086f82/common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala#L379)
for example.
In the current PR as well, the fallbacks are exercised in the tests - the
configs are set as users would set them (so not for lifecycle manager, as that
is internal), while the test itself would be for the internal module - and so
the configs resolution would exercise fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
